Support the new flow used in Authentik #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1350 +/- ##
===========================================
- Coverage 42.19% 29.01% -13.18%
===========================================
Files 54 70 +16
Lines 6456 9667 +3211
===========================================
+ Hits 2724 2805 +81
- Misses 3283 6391 +3108
- Partials 449 471 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authentik introduced the new authentication flow in this PR: goauthentik/authentik#10296. Basically the change is they switched from using
typefield to just using differentcomponentfields for different operations in the flow.This PR addresses these changes. Now saml2aws works with recent Authentik version (2024.8.3 at a time), but considering I kept tests for previous flow and they still pass, it should work with older Authentik versions as well.
P.S. I'm not that proficient golang developer, so I would appreciate any suggestions, if any.